Skip to content

Comments

VS Code improvements + Rust server nit#25

Merged
timbod7 merged 2 commits intoadl-lang:masterfrom
alexytsu:upstream-pr
Apr 17, 2025
Merged

VS Code improvements + Rust server nit#25
timbod7 merged 2 commits intoadl-lang:masterfrom
alexytsu:upstream-pr

Conversation

@alexytsu
Copy link
Contributor

Two unrelated commits:

QoL in VS Code

  • Recommended extensions for LSP to work properly in Deno, Rust and Typescript (last outstanding nit is to have deno fmt run on save in the deno subdir rather than prettier)
  • Default to non-relative imports in the ts subdir. Promotes consistency and since we have the aliases set up anyway, makes it easier to refactor/move files around.
  • Integrated VS Code terminal opens with the local tooling in $PATH (don't need to remember run . deno/local-setup.sh)

Rust server nit:

  • Bubble up fatal errors in the server and print them (previously silently failing on errors e.g. if port was already taken)

@alexytsu alexytsu marked this pull request as ready for review April 16, 2025 00:43
Copy link
Contributor

@timbod7 timbod7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM


inject_secrets(&mut config)?;
server::run(config).await;
server::run(config).await?;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm surprised that this snuck in. I though the compiler warned when results were not consumed. Perhaps not with async...

@timbod7 timbod7 merged commit 4fe4ea5 into adl-lang:master Apr 17, 2025
2 checks passed
@alexytsu alexytsu deleted the upstream-pr branch May 1, 2025 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants